search

simonmicro / better-backgrounds

A Cinnamon desktop applet to change your wallpaper to random images from many sources
GNU General Public License v3.0
2 stars 1 forks source link

Updates to be compatible with Mint 21.3 #25

Open mdepa opened 9 months ago

mdepa commented 9 months ago

Mint 21.3 upgraded Cinnamon to use Soup 3 as backend messaging layer.

Updated applet to correctly use such new version in addition to the well known Soup 2 lib.

mdepa commented 9 months ago

I mistakenly created a PR from the fork targeting the main repo: sorry for the issue I really don't want to dirt the original applet.

simonmicro commented 9 months ago

Heyho, your changes are always welcome :grin: - may I ask what the binary blob should be? I assume it is a picture, but then you should not just add it to the repository (especially if you are not the creator and have the correct license).

mdepa commented 9 months ago

Hi,

this change was really not meant to get included into main repo: github by default creates merge requests toward original repo in place of forked one and I didn't notice it at first, sorry for the inconvenience.

Anywaym I think you deserve some explanations about my changes: I've added fediverse support to better-backgrounds starting with Mastodon, which is a messaging platform like X, and then I'd like to add pixelfed, which is more picture oriented and so, probably, more suitable with the applet goal..

In my branch I've changed applet's UUID 'cause while developing it, I've the original installed too, so I think you'd won't merge it as is, so please, drop this MR.

If you think it could be worth to add my contribution to better-backgrounds, I can prepare a better/cleaner contribution preserving original applet name and with cleaner content, just let me know, in case.

Thanks a lot for your work and support.

simonmicro commented 3 weeks ago

Hey @mdepa I really think the work in your fork deserves to be merged into this upstream! I think in combination with your extensions I'll then also update the ongoing #26 issue and we have a beautiful, better release :) What do you think?

mdepa commented 3 weeks ago

Ciao,

sure, it would be great and I'll be very happy to contribute to your beautiful extension.

I fully agree and thanks,

M

Da: simonmicro @.> Inviato: lunedì 14 ottobre 2024 15:16 A: simonmicro/better-backgrounds @.> Cc: Mauro de Pascale @.>; Mention @.> Oggetto: Re: [simonmicro/better-backgrounds] Updates to be compatible with Mint 21.3 (PR #25)

Hey @mdepahttps://github.com/mdepa I really think the work in your fork deserves to be merged into this upstream! I think in combination with your extensions I'll then also update the ongoing #26https://github.com/simonmicro/better-backgrounds/issues/26 issue and we have a beautiful, better release :) What do you think?

— Reply to this email directly, view it on GitHubhttps://github.com/simonmicro/better-backgrounds/pull/25#issuecomment-2411240985, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADZMH3NQAJVIGWHRLICFDVLZ3O74JAVCNFSM6AAAAABP47TZYCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJRGI2DAOJYGU. You are receiving this because you were mentioned.