simonmitchell / rocc

A Swift framework for remote control of digital Cameras
MIT License
119 stars 15 forks source link

isConnected does not update to true. #26

Open henningdekode opened 4 years ago

henningdekode commented 4 years ago

Steps to reproduce:

Connect to camera observe isConnected after: camera.connect { (error, isInTransferMode) in

Actual behavior:

isConnected is false

Expected behavior:

isConnected should be true

System configuration

Mac OS iOS 13.3.1 Sony A9

Rocc version:

iOS/macOS version:

iOS 13.3.1

Camera manufacturer and model:

Sony A9

Other information about your system(s):

Other questions

Does the issue still occur after updating your Camera's Firmware?

Have you tried any other versions of NVDA?

simonmitchell commented 4 years ago

I will look into this for you when I get a chance! I don’t tend to use this myself personally ☺️ It’s more just a leftover from when I originally created the Camera protocol! I’ll get this fixed in 2.0.0 probably!

simonmitchell commented 4 years ago

Hi @henningdekode

I think I'm actually going to remove this property, in favour of simply using the device connectivity notifier class. Do you have any particular use-case for this? I don't use it at all myself in Camrote and it's actually quite difficult to define "connectiveness" given the state of connection is mostly controlled camera side, and with the API control mechanism basically only requires you to be on the same WiFi network!

What are your thoughts?