simonpacis / obsidian-grammarly-plugin

Add Grammarly spellchecking to Obsidian.md.
GNU General Public License v3.0
234 stars 11 forks source link

Embedded PDF's break Grammarly #2

Open rupeshknn opened 2 years ago

rupeshknn commented 2 years ago

Hi, I have installed and enabled the plugin. But none of the errors is being highlighted.

image

Here is the console output:

'Uncaught TypeError: Cannot read properties of undefined (reading 'grammarlySkip')
    at Yr (grammarly-editor-sdk@2.0?clientId=client_SZRuwBMe5opCznxqMQCG3q&packageName=%40grammarly%2Feditor-sdk:17:94237)
    at pd._hTb (grammarly-editor-sdk@2.0?clientId=client_SZRuwBMe5opCznxqMQCG3q&packageName=%40grammarly%2Feditor-sdk:17:396297)
    at grammarly-editor-sdk@2.0?clientId=client_SZRuwBMe5opCznxqMQCG3q&packageName=%40grammarly%2Feditor-sdk:17:397345
    at NodeList.forEach (<anonymous>)
    at pd._hTb (grammarly-editor-sdk@2.0?clientId=client_SZRuwBMe5opCznxqMQCG3q&packageName=%40grammarly%2Feditor-sdk:17:397308)
    at grammarly-editor-sdk@2.0?clientId=client_SZRuwBMe5opCznxqMQCG3q&packageName=%40grammarly%2Feditor-sdk:17:397345
    at NodeList.forEach (<anonymous>)
    at pd._hTb (grammarly-editor-sdk@2.0?clientId=client_SZRuwBMe5opCznxqMQCG3q&packageName=%40grammarly%2Feditor-sdk:17:397308)
    at grammarly-editor-sdk@2.0?clientId=client_SZRuwBMe5opCznxqMQCG3q&packageName=%40grammarly%2Feditor-sdk:17:397345
    at NodeList.forEach (<anonymous>)
Yr @ grammarly-editor-sdk@2.0?clientId=client_SZRuwBMe5opCznxqMQCG3q&packageName=%40grammarly%2Feditor-sdk:17
_hTb @ grammarly-editor-sdk@2.0?clientId=client_SZRuwBMe5opCznxqMQCG3q&packageName=%40grammarly%2Feditor-sdk:17
(anonymous) @ grammarly-editor-sdk@2.0?clientId=client_SZRuwBMe5opCznxqMQCG3q&packageName=%40grammarly%2Feditor-sdk:17
_hTb @ grammarly-editor-sdk@2.0?clientId=client_SZRuwBMe5opCznxqMQCG3q&packageName=%40grammarly%2Feditor-sdk:17
(anonymous) @ grammarly-editor-sdk@2.0?clientId=client_SZRuwBMe5opCznxqMQCG3q&packageName=%40grammarly%2Feditor-sdk:17
_hTb @ grammarly-editor-sdk@2.0?clientId=client_SZRuwBMe5opCznxqMQCG3q&packageName=%40grammarly%2Feditor-sdk:17
(anonymous) @ grammarly-editor-sdk@2.0?clientId=client_SZRuwBMe5opCznxqMQCG3q&packageName=%40grammarly%2Feditor-sdk:17
_hTb @ grammarly-editor-sdk@2.0?clientId=client_SZRuwBMe5opCznxqMQCG3q&packageName=%40grammarly%2Feditor-sdk:17
(anonymous) @ grammarly-editor-sdk@2.0?clientId=client_SZRuwBMe5opCznxqMQCG3q&packageName=%40grammarly%2Feditor-sdk:17
_hTb @ grammarly-editor-sdk@2.0?clientId=client_SZRuwBMe5opCznxqMQCG3q&packageName=%40grammarly%2Feditor-sdk:17
(anonymous) @ grammarly-editor-sdk@2.0?clientId=client_SZRuwBMe5opCznxqMQCG3q&packageName=%40grammarly%2Feditor-sdk:17
_hTb @ grammarly-editor-sdk@2.0?clientId=client_SZRuwBMe5opCznxqMQCG3q&packageName=%40grammarly%2Feditor-sdk:17
encode @ grammarly-editor-sdk@2.0?clientId=client_SZRuwBMe5opCznxqMQCG3q&packageName=%40grammarly%2Feditor-sdk:17
(anonymous) @ grammarly-editor-sdk@2.0?clientId=client_SZRuwBMe5opCznxqMQCG3q&packageName=%40grammarly%2Feditor-sdk:17
Gt @ grammarly-editor-sdk@2.0?clientId=client_SZRuwBMe5opCznxqMQCG3q&packageName=%40grammarly%2Feditor-sdk:17
updateText @ grammarly-editor-sdk@2.0?clientId=client_SZRuwBMe5opCznxqMQCG3q&packageName=%40grammarly%2Feditor-sdk:17
(anonymous) @ grammarly-editor-sdk@2.0?clientId=client_SZRuwBMe5opCznxqMQCG3q&packageName=%40grammarly%2Feditor-sdk:17
rupeshknn commented 2 years ago

Sometimes it shows the number of suggestions in the icon bellow. But still no underlining errors.

rupeshknn commented 2 years ago

I think I figured it out. The error is happening because of a pdf file embedded in the file. Once I removed the embed, it works now. But this is still a bug. Ideally, skip the pdf embed and correct the rest of the document.

simonpacis commented 2 years ago

Hi rupeshknn,

Thank you for the bug report :-)

Simon