Selecting empty modifier crashes Vespucci - Githubissues

simonpoole / OpeningHoursFragment

Android UI element for displaying and editing an opening hours value

MIT License

9 stars 2 forks source link

Selecting empty modifier crashes Vespucci #43

Closed matkoniecz closed 4 years ago

matkoniecz commented 4 years ago

To reproduce in Vespucci:

add empty opening hours Select Weekdays template Switch modifier for public holidays to empty one

simonpoole commented 4 years ago

The crash is due to an empty string not bing mapped to unknown as it should be according to https://wiki.openstreetmap.org/wiki/Key:opening_hours/specification#section:rule_modifier (and likely the empty selection should not be offered at all).

simonpoole commented 4 years ago

Fixed in https://github.com/simonpoole/OpeningHoursFragment/commit/1eb4c13bfb51a0cf7ff5bb7f93c4d6e749b5d89c and https://github.com/simonpoole/OpeningHoursParser/commit/2c3cf26c6e671bd10eff223d4983af7953191658