Scrolling can change data

simonpoole / OpeningHoursFragment

Android UI element for displaying and editing an opening hours value

MIT License

9 stars 2 forks source link

Open HolgerJeromin opened 4 years ago

HolgerJeromin commented 4 years ago

Repo: Open a long entry like: Mo 16:00-22:00; Tu-Th 12:00-23:00; Fr-Sa 12:00-24:00; PH,Su 12:00-22:00

Scroll down (touchstart, swipe down, touch end) to see more of it:

If the touchdown was outside or inside the timerange does not scroll, but opens a time select dialog.

If the touchdown was at a start/end time I can scroll, but the time is often changed subtle by 15 minutes.

simonpoole commented 4 years ago

Dragging vertically should not open the dialog.

simonpoole commented 4 years ago

THis is actually an issue with the RangeBar as far as I can tell. Workaround is to scroll with a rules header or other safe location.

HolgerJeromin commented 4 years ago

Same problem on the three menu points if you wait a few hundred milliseconds between touchstart and touchmove. The menu popups.