search

simonpoole / OpeningHoursFragment

Android UI element for displaying and editing an opening hours value
MIT License
9 stars 2 forks source link

Request for translation update #45

Closed iriman closed 4 years ago

iriman commented 4 years ago

Persian translation of OpeningHoursParser and OpeningHoursFragment on transifex is complete, but isn't available on Vespucci.

simonpoole commented 4 years ago

Which version of vespucci were you looking at?

iriman commented 4 years ago

Currently latest version from Google Play (15.0.1). Previously also on 14.x. Actually I haven't seen Persian translation for this since translation on transifex.

simonpoole commented 4 years ago

hmmm I need to check on this.

simonpoole commented 4 years ago

The translation is available when I try here (the vespucci introduction seems to be missing though).

iriman commented 4 years ago

That's strange... Some screenshots from my android 7.1.1 with Persian locale: Preferences (OK): ۲۰۲۰۰۸۱۸_۱۸۲۸۴۸

When I tap 2nd item from buttom (manage template): ۲۰۲۰۰۸۱۸_۱۸۲۹۳۵

۲۰۲۰۰۸۱۸_۱۸۳۰۴۰

Or when I want to edit opening hours within form: ۲۰۲۰۰۸۱۸_۱۸۳۰۰۹

simonpoole commented 4 years ago

Seems as if the last build didn't include the translations properly, rebuilt and reincluded in Vespucci, works now. https://github.com/MarcusWolschon/osmeditor4android/commit/50180c8867b7ea50f480303e7e97732d6b2e8aec

iriman commented 4 years ago

After updating to 15.0.2 from play store, it was still showing untranslated strings, except for one string (unfortunately I didn't take a screenshot, but the translated one was "collection times" probably). Then I uninstalled and installed Vespucci again. Now almost all are translated. ۲۰۲۰۰۸۲۴_۱۶۰۵۳۵ (Screenshot of manage template screen)