search

simonpoole / OpeningHoursParser

Parser for string values according to the OSM opening hours specification
MIT License
32 stars 12 forks source link

Add `Automatic-Module-Name` for JPMS compatibility #75

Closed tsmock closed 1 year ago

tsmock commented 1 year ago

I've been going through JOSM's dependencies and adding Automatic-Module-Name or module-info.java where applicable.

Pros of Automatic-Module-Name: We don't have to fiddle with the build system. Maven was easy; I've hit some road blocks with gradle. I think it is mostly related to having generated sources. Cons of Automatic-Module-Name: It doesn't allow a project to hide internal packages, but that doesn't matter for this case, since everything is in the same package.

Sample module-info.java file:

module ch.poole.openinghoursparser {
    requires static transitive org.jetbrains.annotations;
    exports ch.poole.openinghoursparser;
}
simonpoole commented 1 year ago

I need to do a couple of checks wrt Android compatibility (that is essentially check that there are no issues with Java 17 bytecode) if everything is fine, I'll tag and build a new release.

You can ignore this, I though you had bumped the Java version but you haven't, I still need to check because I had to move to 17 because AGP 8.1 requires it.