searching "dog" in vespucci should match leisure=dog_park

simonpoole / beautified-JOSM-preset

Improved version of the JOSM presets

http://simonpoole.github.io/beautified-JOSM-preset

Other

58 stars 25 forks source link

searching "dog" in vespucci should match leisure=dog_park #113

Closed matkoniecz closed 5 years ago

matkoniecz commented 5 years ago

I am not sure what should be changed - Vespucci search or is it case that should fixed by adding an alias.

simonpoole commented 5 years ago

This works for me (EN and DE), at least "dog" should always show the item, in other languages it will depend, as we don't really do any steming outside of splitting on space and &, /, . (the later are converted to space during normalisation).

matkoniecz commented 5 years ago

I have EN language set. I will test it and give more detailed info.

matkoniecz commented 5 years ago

I tried "dog" in English UK, English USA, English India, "pies", "psy" on Polish.

Neither gives this dog park result.

Vespucci 11.2.0-1, search for dog shows 7 results (I may attach screenshots if that would be helpful).

simonpoole commented 5 years ago

Well I get (emulator set to EN):

screenshot_1541349144

Do you have any other preset installed that might effect the result?

matkoniecz commented 5 years ago

No, I have just default one installed. I will try reinstalling Vespucci.

matkoniecz commented 5 years ago

I reinstalled Vespucci, without any effects for searching "dog" in English UK.

Would it be helpful to post log output, screenshots or to run a custom debugging build?

simonpoole commented 5 years ago

hmm "English UK"? Can you set the device to the default English aka US?

matkoniecz commented 5 years ago

I tried it already ( https://github.com/simonpoole/beautified-JOSM-preset/issues/113#issuecomment-435682225 ) but I will try again.

"dog" gives "horse racing", "cycling", "racetrack", "equestrian", "running"...

simonpoole commented 5 years ago

The dog park preset itself is present? If yes I'll need to make a custom build to get to the bottom of this (note the issue should really be in the vespucci repo).

matkoniecz commented 5 years ago

The dog park preset itself is present?

Yes.

(note the issue should really be in the vespucci repo).

I thought that it should be solved by adding alias in preset.

simonpoole commented 5 years ago

Does this issue still exist for you?

matkoniecz commented 5 years ago

screenshot_2019-01-21-22-31-41-020_de blau android screenshot_2019-01-21-22-31-33-155_de blau android

Yes.

simonpoole commented 5 years ago

Weird. Is the behaviour the same if you have a node, closed way or multi-polygon selected? Do you have any other presets installed?

matkoniecz commented 5 years ago

node, closed way and multipolygon gets exactly the same results

I have only default preset installed

simonpoole commented 5 years ago

This simply seems to have been a coincidence, if you have your device language set to English (but likely in no other one) "dog" will match so many things (with 0 word matching distance) that dog_park simply isn't in the top 10.

I've tweaked the weighting a bit now so that sub-string matches get an even higher ranking, and now it turns up.

See https://github.com/MarcusWolschon/osmeditor4android/commit/c020e5a1f3565fea6c5e51af74056665eecd79ab