search

simonpoole / beautified-JOSM-preset

Improved version of the JOSM presets
http://simonpoole.github.io/beautified-JOSM-preset
Other
57 stars 25 forks source link

Hazard key values #257

Open davidpnewton opened 3 years ago

davidpnewton commented 3 years ago

Nice to see the new proposal for the hazard key being supported in the preset recently. I have a couple of suggestions for extra values for the key, which whilst not in the proposal would be useful to have.

hazard=frail_pedestrians

This is to represent the British sign diagram 544.2 which is a sign for frail or disabled pedestrians likely to be in the road. It is distinguished from sign diagram 544.1 which is a generic pedestrians in road sign and appears outside places like care home and retirement properties. It is to represent the specific hazard that the frail represent in likely being slower-moving and also more likely to be deaf as a post. Same logic as distinguishing between generic pedestrians in the road and children in the road as they represent different types of danger.

hazard=road_narrows

This covers British sign diagrams 516 and 517 which are the road narrowing ahead either on one or both sides. Again it's a hazard not included in the proposal for some reason.

hazard=other

This would cover situations for British sign diagram 562 which is a form of hazard not otherwise covered by a sign. So it's a catch-all to deal with signposted hazards not otherwise represented.

Same icon to be used for the sign in the rendering, just some extra options.

Lee-Carre commented 2 years ago

I've been (manually) adding hazard=electrocution to the likes of power=substation & power=pole. Particularly since relevant signage makes quite clear that there's a “danger of death” to anyone messing with such equipment.

Besides populating the values list for the hazard key itself, might I suggest also adding a relevant hazard=* tag to other presets, for consistency.

simonpoole commented 2 years ago

@Lee-Carre noted. I'll have a look at expanding the list for next month.

Do you know you can create a custom preset on the fly in Vespucci? See http://vespucci.io/help/en/14.0.0%20Release%20notes/#on-the-fly-custom-presets so while not as good as a pre-made preset this can work as a stopgap measure.

Lee-Carre commented 2 years ago

Do you know you can create a custom preset on the fly in Vespucci?

Indeed, thankyou for the reminder 🙂. I've been making use of them, on occasion. Though, as you say, they have their limitations.

A local workaround is never as good as addressing the problem upstream (for everyone's benefit). Hence my previous comment 😉.

simonpoole commented 2 years ago

Additional traffic hazard values added in https://github.com/simonpoole/beautified-JOSM-preset/commit/b14993b04eb0f690769f9c66b413b5ae396da101 However none of these currently have a wiki page, which iMHO you should add.

The question with hazard=electrocution is interesting, because there is currently no documentation of hazard values that are neither traffic related, or areas. I don't see a reason to go through a proposal process for this, but it might be something worth mentioning on the tagging mailing list for feedback.

davidpnewton commented 2 years ago

Just added wiki pages for frail_pedestrian and road_narrows.