simonpoole / beautified-JOSM-preset

Improved version of the JOSM presets
http://simonpoole.github.io/beautified-JOSM-preset
Other
58 stars 25 forks source link

Fire hydrant preset assumes `fire_hydrant:type=pillar` #288

Closed Lee-Carre closed 2 years ago

Lee-Carre commented 2 years ago

I've been adding fire hydrants (outside America, in Europe), and the FH preset auto-(adds|sets) fire_hydrant:type=pillar. This may be fine in North American nations, but in my area (and I think the rest of the British Isles, too) they're all fire_hydrant:type=underground (at least, I've never encountered any other type).

So, would it be possible to not auto-set the value of fire_hydrant:type, so that it must be manually set (else the tag ends up not included in the changeset). Thus far, I have to remember to manually correct it, each time. However, I can foresee that being missed, at some point in future. It would seem better to not auto-specify it (especially since StreetComplete has a quest for FH type).

Unless there's some way of setting defaults per-nation: fire_hydrant:type=pillar for North America, fire_hydrant:type=underground for Britain.

simonpoole commented 2 years ago

It's completely possible to have per-country preset items, see http://vespucci.io/tutorials/presets/#extensions , but I suspect that simply removing the default might be the better approach here.

Lee-Carre commented 2 years ago

It's completely possible to have per-country preset items

Good to know 💡.

I suspect that simply removing the default might be the better approach here.

I'm inclined to concur.

Lee-Carre commented 2 years ago

Simply for amusement:

… in my area … they're all fire_hydrant:type=underground (at least, I've never encountered any other type).

… there's surely some exception in each continent.

I think I found such an example, locally, recently (read the values of (fixme|note):position).

So, removing the auto-set default, instead of per-nation defaults, seems to have been the correct remedy.