search

simonpoole / beautified-JOSM-preset

Improved version of the JOSM presets
http://simonpoole.github.io/beautified-JOSM-preset
Other
57 stars 25 forks source link

Use different icons for sport=horse_racing,, sport=equestrian and leisure=horse_riding #305

Open Hufkratzer opened 2 years ago

Hufkratzer commented 2 years ago

JOSM's default presets use different icons for

but you use the same icon (sport_horse_racing.png) for all 3 tags (see http://simonpoole.github.io/beautified-JOSM-preset/).

I wonder why this is so. Although I admit that your icon is more beautiful, I think in general it is not helpful for the user to have the same icon used for different things. What about using different icons for sport=equestrian and leisure=horse_riding? Perhaps you can use the icons that were made during a discussion some years ago in https://github.com/gravitystorm/openstreetmap-carto/issues/2344#issuecomment-357300647 ff. For example, for tag sport=equestrian it could look like this: sport_equestrian.svg. Or would it be better to update the icons in JOSM so that you don't need own versions?

simonpoole commented 2 years ago

The reason that this is so is that creating a new icon is a substantial amount of work and very often when differ in only minor details the differences are not actually visible for the user.

That said, if you have suitable, CC0 licensed, icons pls add them to this issue and I'll have a go at adding them.