search

simonpoole / beautified-JOSM-preset

Improved version of the JOSM presets
http://simonpoole.github.io/beautified-JOSM-preset
Other
58 stars 25 forks source link

Searching for shed only finds building part #366

Closed jidanni closed 1 year ago

jidanni commented 1 year ago

https://wiki.openstreetmap.org/wiki/Tag:building%3Dshed should appear when we search for shed.

simonpoole commented 1 year ago

We don't maintain synonyms here (not the least because the JOSM format doesn't support them).

If you are looking for the source of synonyms Vespucci uses, we use those added via translations to https://github.com/openstreetmap/id-tagging-schema

tyrasd commented 1 year ago

@simonpoole I don't understand why you linked the id-tagging-schema repository here? It does already have a preset for building=shed with the name "Shed", but still Vespucci does not find it when searching for it. Obviously, this is because Vespucci is not actually using the id-tagging-schema for presets, but only using it partially to get synonyms, which does not work out well in this case. What would you propose to be done to fix this issue?

simonpoole commented 1 year ago

@tyrasd @jidanni confusingly opened two issues. The actual issue was that he was searching for "workshop" and didn't get "shed" or rather the general building preset as one of the results (searching for "shed" does return the building preset). That is technically down to the synonyms / terms not containing "workshop" (which I see you've added in the meantime).

Now if it is even reasonable to expect every thing mentioned in the wiki to somehow magically turn up in the synonyms is a different question. I would respectfully suggest that if a user wants that, they should set aside a day or two per week to work on it.