simonpoole / beautified-JOSM-preset

Improved version of the JOSM presets
http://simonpoole.github.io/beautified-JOSM-preset
Other
57 stars 25 forks source link

The new chunk “departures_board” has a few errors #425

Closed jajajaneeneenee closed 10 months ago

jajajaneeneenee commented 10 months ago

The multiselect has no text attribute and display_values="XY" should be display_value="XY":

        <multiselect key="departures_board">
            <list_entry value="yes" display_values="Available"/>
            <list_entry value="timetable" display_values="Timetable"/>
            <list_entry value="realtime" display_values="Realtime display"/>
            <list_entry value="no" display_values="None"/>
        </multiselect>

It could be changed like this:

        <multiselect key="departures_board" text="Departures board">
            <list_entry value="yes" display_value="Available"/>
            <list_entry value="timetable" display_value="Timetable"/>
            <list_entry value="realtime" display_value="Realtime display"/>
            <list_entry value="no" display_value="None"/>
        </multiselect>

And perhaps, the (questionable?) key "delay" could be added (taginfo says: 603 uses)?

jajajaneeneenee commented 10 months ago

Another suggestion: you should add match="key" to the multiselect – then the new item "Departures board" (which uses the chunk) will also match with multiple values like departures_board=realtime;timetable! I tried it out ...

Without match="key" only single values will match ...

Therefor I would suggest to use a code like this:

        <multiselect key="departures_board" text="Departures board" match="key">
            <list_entry value="yes" display_value="Available"/>
            <list_entry value="timetable" display_value="Timetable"/>
            <list_entry value="realtime" display_value="Realtime display"/>
            <list_entry value="no" display_value="None"/>
        </multiselect>
jajajaneeneenee commented 10 months ago

You forgot to change display_values to display_value in thelist_entrylines. (Values will be shown in lowercase letters.)