search

simonpoole / beautified-JOSM-preset

Improved version of the JOSM presets
http://simonpoole.github.io/beautified-JOSM-preset
Other
57 stars 25 forks source link

tower:construction values for man_made=mast and man_made=tower incorrectly assigned (swapped)? #452

Closed jajajaneeneenee closed 4 months ago

jajajaneeneenee commented 4 months ago

In this commit you assigned these values for tower:construction to man_made=tower:

<combo key="tower:construction" text="Tower construction" values="freestanding,guyed_lattice,guyed_tube,lattice"
display_values="Freestanding,Guyed lattice,Guyed tube,Lattice" editable="true" match="key" values_searchable="true"/>

And these values to man_made=mast:

<combo key="tower:construction" text="Tower construction" values="dish,dome,freestanding,lattice"
display_values="Dish,Dome,Freestanding,Lattice" editable="true" match="key" values_searchable="true"/>

But doesn't it have to be the other way around? In the wiki, the values ​​lattice/freestanding/dish/dome (and concealed) are listed for man_made=tower and freestanding/guyed_lattice/guyed_tube/lattice for man_made=mast. Which, I think, makes sense.

And by the way: at the end of the item forman_made=mast is a wrong comment: <!-- Tower --> (I saw this also at other items, maybe you could check this in an automated way.)