simonpoole / beautified-JOSM-preset

Improved version of the JOSM presets
http://simonpoole.github.io/beautified-JOSM-preset
Other
57 stars 25 forks source link

Sport items like “Climbing site“ don't match in Vespucci #458

Closed jajajaneeneenee closed 2 months ago

jajajaneeneenee commented 2 months ago

Your new item “Climbing site“ (sport=climbing) doesn't match if a node is tagged like that (which is fine e.g. for artificial climbing walls according to the Wiki). The result is: no icon on the map, no matching in the editor.

sport_climbing_21005

I think ”sport” could be added to the object_keys – then also other sport items (like “Soccer“) will match (although they should have a main tag like leisure=pitch, leisure=sports_centre or leisure=stadium according to the Wiki).

Or – if sport=climbing should be seen as an exception (can also be used without a main leisure=*tag) – then perhaps object=true could be added in its item. I tried it out and this also worked.

simonpoole commented 2 months ago

Duplicate of https://github.com/simonpoole/beautified-JOSM-preset/issues/453

jajajaneeneenee commented 2 months ago

Not planned ... OK ...

It would still be nice to get some feedback on whether you also see a problem with it or why not (for Vespucci).

Because I don't quite understand the concept of items like "Climbing site" (fixed key-value pair sport=climbing) for Vespucci. You can find the item in the list in the editor (or of course by preset search for "Climbing, but after you have assigned it to a new node, for example, you don't see an icon on the map, nor does the item match in the editor when you call up the node again to edit it.

And there is also no warning/information message that, for example, a main tag such as leisure=pitch or the like is missing.

In JOSM it is fundamentally different, as there is a kind of "multiple matching" for all items with matching fixed key-value pairs). And a node tagged only with sport=climbing is also displayed with a climbing icon on the map. (When uploading, there is then the validator warning "missing tag - sport without physical feature").

For Vespucci, I see a conceptual gap here.

Perhaps one could think about a kind of "second level matching" for Vespucci with an appropriate fixed key-value pair without a "real" ("is object") match of an item (perhaps with a validator warning "main tag missing"?), but with matching of such an item when editing - comparable to JOSM - (with a special, e.g. different colored warning display when editing?) Or another solution...

And the case of "sport=climbing" without a main tag has crossed my path several times now (in the real world), especially with climbing walls on buildings – and for that reason it is currently described in the wiki without a leisure main tag (as the only sport tag as far as I know). But it results in Osmose error messages, for example. I have already thought about whether one should assign leisure=pitch for such cases and view the climbing wall as a kind of "vertical sports field", which is what it actually is – if necessary, it could also be described like this in the wiki and this "exception" would be eliminated. Individual table tennis tables, for example, are also tagged with leisure=pitch ... so “pitch” is already being interpreted broadly.

Which does not solve the problem with the (non-)matching of the sport items in Vespucci if a main tag is missing ...

simonpoole commented 2 months ago

The thing you missed is "Duplicate of https://github.com/simonpoole/beautified-JOSM-preset/issues/453"*

jajajaneeneenee commented 2 months ago

Don't understand what you mean ... #453 is about Climbing routes. That's why I also didn't understand why it's a duplicate.