simonpoole / beautified-JOSM-preset

Improved version of the JOSM presets
http://simonpoole.github.io/beautified-JOSM-preset
Other
58 stars 26 forks source link

Issue #470 wasn't fixed correctly #471

Closed jajajaneeneenee closed 1 month ago

jajajaneeneenee commented 1 month ago

Issue #470 wasn't fixed correctly in this commit – because #470 is already closed, I open a new one ... I hope this is the usual procedure.

In the item "Regional hiking network junction", you simply changed:

I wrote in #470 that it should have the name "Regional horse riding network junction" (with key="rhn_ref") and the icon should show a horse, not a hiking symbol ... I didn't write that you should change it to key="rwn_ref" for good reason. Because:

  1. There was (and still is) already an item for the key="rwn_ref": item name="Regional walking network junction" Now 2 items with the same matching exist (only with different icons and an error in the 2nd one, see next point).
  2. In addition, the modified item item name="Regional hiking network junction" now has this error: there is also a code line which still has a "rhn" key: <text key="expected_rhn_route_relations" text="Expected route count" match="none" value_type="integer"/>. So now there is "rwn" and "rhn" mixed (walking and horse riding).

Result/summary: If you don't want to have a "Regional horse riding network junction", simply delete the item "Regional hiking network junction" (with the new error described in 2).

Note: The term "hiking" does not appear in the context of these network nodes. I'm not an expert with these nodes, I just read it in the wiki. There it's always called "walking" (abbreviation "w") – therefore, I would avoid to use "hiking" in the item name (or as a symbol in the icon). I think "Regional walking network junction" (which already exists) is fine ...