tourism=attraction icon should have lowest priority

[matkoniecz]

For example historic=wayside_cross should display wayside cross icon, also when tagged as tourism attraction, as attraction icon is not specific - anything may be an attraction

I am not sure is it issue in preset or Vespucci itself or both

[simonpoole]

There is currently no way to convey such information in the JOSM preset format, vespucci does grade matched presets according to the number of matched tags per preset , however an object tagged with say

tourism=attraction historic=wayside_cross

will have the same weight for both objects and which one "wins" will depend on the order of the tags in processing.

[SomeoneElseOSM]

Isn't this something that a renderer would handle? In the tourist attraction / wayside cross example a renderer that was interested in historic stuff might ignore tourism=attraction altogether, and vice versa for a "tourism focused" rendering. If something is tagged with both X and Y there's nothing implicit in the tagging to say X is more important than Y or Y more important than X, but a given renderer will surely want to do that.

[simonpoole]

@SomeoneElseOSM well the renderer in question is the Vespucci OSM data display which tends to be "topic" neutral (for obvious reasons :-)). One day we might simply render multiple icons in such situations, but for now we simply need to pick a winner.

In practice the weighting generated by the preset matcher works well, but tourism=attraction is just one of those OSM tagging oddities that is difficult to handle without hard coding things.

tourism=attraction is used as an attribute tag (using a toplevel object key (tourism) ), at least when used together with a different toplevel object for example historic=* (or even more confusingly attraction=* ). On the other hand it is also used as a stand alone object. Vespucci already uses an extension to the JOSM preset format to indicate which keys should be considered "real world objects" which covers most cases of non-attribute-only keys, but as said tourism=attraction is both.

[simonpoole]

See https://github.com/simonpoole/beautified-JOSM-preset/issues/82

[matkoniecz]

On the other hand it is also used as a stand alone object

It is always a tagging mistake. tourism=attraction always should be added as additional info to real feature

[simonpoole]

Well that was a decision made by you last September, prior to that it was just "often" used as additional info.

Which explains why of the 162'000 uses of it a majority is stand alone. Note I'm not saying that such a tag as an attribute for other objects isn't necessary, just that using a key that otherwise indicates a "primary feature" / real world object, is sub-optimal.

[matkoniecz]

I am unable to imagine case (and I never encountered one) where tourism attraction exists without anything that should be tagged.

And many, many unfinished maps.me edits are not changing that.

[simonpoole]

That's not the problem, the problem is requiring special semantics for one tag out of thousands.