esprima is not automatically installed

simonrenoult / code-complexity

Measure the churn/complexity ratio. Higher values mean hotspots where refactorings should happen.

MIT License

281 stars 28 forks source link

esprima is not automatically installed #43

Open berkes opened 1 year ago

berkes commented 1 year ago

When I run 4.0.0 using the example from the readme, npx then it fails with

Error: Cannot find module 'esprima'

Installing with npm install code-complexity also does not pull it in. Explicitly installing with npm install esprima solves the issue.

I'm no nodejs expert, so I don't know how to present a fix for this -I'm not familiar with bundleDependencies- but I suspect something in the package.json is off, or some vendored package should be included.

cope commented 1 year ago

Probably did not execute npm pack before publishing?

See bundleDependencies.

rluvaton commented 1 year ago

@simonrenoult could you please republish with esprima?

adrienjoly commented 1 year ago

Apparently, this problem appeared in v4.3.0, because v4.2.2 is still working on my end.

RonaldZielaznicki commented 1 year ago

The root of this problem stems from escomplex. https://github.com/escomplex/escomplex/issues/206

escomplexV2.0.0-alpha (commit) is the version referenced here and on npm. That versions package.json has esprima as a devDependency rather than a dependency.