search

simonridley / tracking-code-manager

2 stars 5 forks source link

Fix Undefined array key "scripts" error #4

Closed kevinmeijer97 closed 2 years ago

kevinmeijer97 commented 2 years ago

Fix Undefined array key "scripts" error that appears after installing the package and not changing the settings.

simonridley commented 2 years ago

Thanks @kevinmeijer97 for the PR, can you check should it not be:

if(!isset($values['enabled']) || $values['enabled'] == false || !isset($values['scripts'])){

(&& changed to ||)

kevinmeijer97 commented 2 years ago

My bad, you are correct. I updated the PR :)

simonridley commented 2 years ago

Brilliant thanks for the contribution 👍