Final project feedback

[kuldeep23907]

Hi Simon - I am Kuldeep, one of the mentors who assisted in grading the projects. Congratulation, your Final Project passed! Here is feedback on the same.

The concept of the project is very new and seems like a good use case of blockchain. It's good to have an understanding of the valid use cases of blockchain technology.

Front-end

• UI is simple and easy to use.
• Awesome work on making it user interactive, especially when switching addresses or switching networks in metamask.
• Nice to use Netlify for deploying FE, GitHub-pages could have been an option too.

Testing

• Sufficient unit testing of the smart contract.
• This could have been grouped in a better way using "describe" for similar test cases.
• It's a good practice to delete unused code or unused variables or unused libraries. Several test cases have unused variables & "time" has been imported but never used.
• Include unit test to check if events are being emitted or not using expectEvent.

Smart Contract

Nice work on smart contracts. Good use-case of ERC721, ERC20, error keyword, events, and other solidity concepts. I see you understand how inter-contract execution works (b/w Bond Market & Bond Token). Open-zeppelin contracts such as Access-control(RBAC), ERC721, Pausable have been used, nice. Why BondToken's mint method is public, whereas safeMint has permission? Do you think BondMarket needs receive() and withdraw() method?

Overall

The project is overall good. Simple front-end, good testing & nice work on smart contracts. Would love to see you participating in hackathons & working on awesome projects.

Hope you enjoyed the learning journey so far and can continue building on this.

[simonroope]

Hi @kuldeep23907 Many thanks for taking the time to review my project and provide detailed feedback. There is much for me to consider and I'm pleased to know also much for me to take on my journey to the next level. Many thanks.