search

simonrouard / CRASH

45 stars 4 forks source link

Some minor errors I detected #2

Open eloimoliner opened 2 years ago

eloimoliner commented 2 years ago

Hi, Thanks for your nice contribution! I detected a couple of errors that maybe you would like to correct: Here: https://github.com/simonrouard/CRASH/blob/4cf336706bafdcd7277370ddf987b2f4d559e032/getters.py#L20 sigma_min and sigma_max are not required for the constructor of VpSdeCos. Same for the other SDEs. And here: https://github.com/simonrouard/CRASH/blob/4cf336706bafdcd7277370ddf987b2f4d559e032/learner.py#L142 "self.sde_t" is not defined. Maybe it should be "self.sde"?

simonrouard commented 2 years ago

Hi @eloimoliner, indeed there is a typo, the first on should be 'return VpSdeCos()'. The second one is 'self.sde' instead of 'self.sde_t'