search

simonrw / ttvfast-python

Python interface to the TTVFast library
GNU General Public License v2.0
15 stars 6 forks source link

Update for adjusted TTVFast.c functionality #19

Open sealauren opened 5 years ago

sealauren commented 5 years ago

Hi Simon,

I have made a branch of the ttvfast-python code (branch verbose-output) in which I am updating TTVFast.c to print out the asterocentric coordinates (a, e, i, om, Om, M) of each planet at each step. I am also printing out the component of the RV from each of the planets at each time step. Or better yet, instead of printing these variables, it would be great to store them to memory.

What is best way to implement these changes? One possibility is to update TTVFast.c directly and to include an optional -verbose argument that prints the output. Another possibility is to copy TTVFast.c to a new program, TTVFast-verbose.c, and call version of TTVFast separately.

Which of these approaches (or what other approach) seems easiest to maintain going forward? Would you be willing to pull these changes into the ttvfast-python git repo? Also, what other programs will I need to update/write to get ttvfast-python to run with the modified TTVFast.c or the new TTVFast-verbose.c?

Thanks,

Lauren

simonrw commented 5 years ago

I prefer the first option - add a verbose flag to the C code. That way any changes that need to be made to the main algorithm only need to be applied once.

I'm happy to take a look, I will probably add a verbose flag to the python API as well to enable this feature.

simonrw commented 5 years ago

How do you feel about me giving you commit permissions? This would make you a joint owner to the repository, and minor tweaks that need to be made can be done by you. I'm having less time to work on this project, and I appreciate you handling other issues (#18) for me.

sealauren commented 5 years ago

Hi Simon,

Sure, I'd be happy to help. My git branch-push-pull skills are finally good enough that I can probably do more good than harm.

I'll look into adding verbose output to TTVFast.

Best,

Lauren

On Wed, Nov 7, 2018 at 8:52 AM Simon Walker notifications@github.com wrote:

How do you feel about me giving you commit permissions? This would make you a joint owner to the repository, and minor tweaks that need to be made can be done by you. I'm having less time to work on this project, and I appreciate you handling other issues (#18 https://github.com/mindriot101/ttvfast-python/issues/18) for me.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mindriot101/ttvfast-python/issues/19#issuecomment-436736121, or mute the thread https://github.com/notifications/unsubscribe-auth/ABRTfrEQzJ-pMD3jIYXPBDYMcxsEIrBxks5usyvggaJpZM4X29z_ .

simonrw commented 5 years ago

Great, thanks! If you push your branch up to the repo (now that you're a joint owner) then I can take a look at integrating.

simonrw commented 5 years ago

Hi Lauren, have you been able to make progress on this?

sealauren commented 5 years ago

Sorry I've been busy with other code development and advising.

simonrw commented 5 years ago

That's ok, I don't think there is a rush! I was just going over my open issues yesterday.

On Mon, 10 Dec 2018, 21:27 Lauren Weiss <notifications@github.com wrote:

Sorry I've been busy with other code development and advising.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/mindriot101/ttvfast-python/issues/19#issuecomment-445979828, or mute the thread https://github.com/notifications/unsubscribe-auth/AADpbHSLOgJJZ_ylzupkmatujQJNF8_dks5u3tGngaJpZM4X29z_ .