Fix 'SyntaxWarning: "is" with a literal. Did you mean "=="?' warning in engine.py

simons-public / protonfixes

A module for applying fixes at runtime to unsupported games with Steam Proton without changing game installation files

https://simons-public.github.io/protonfixes/

Other

233 stars 114 forks source link

Fix 'SyntaxWarning: "is" with a literal. Did you mean "=="?' warning in engine.py #98

Closed mrjackv closed 4 years ago

mrjackv commented 4 years ago

Python 3.8 has introduced a warning when the is operator is used inappropriately (see this for a thorough explanation)
The gist of the problem is that the use of the is operator for string comparison accidentally works on CPython (the standard python interpreter) however such behavior is not guaranteed with other python implementations or future versions of CPython This PR replaces the is operator with == where applicable.