search

simonschaufi / laravel-dkim

Laravel package for signing outgoing messages with DKIM
https://www.simonschaufelberger.de/de/projekte/laravel-packages/laravel-dkim.html
MIT License
24 stars 9 forks source link

Update installation instructions #17

Closed adi64 closed 11 months ago

adi64 commented 11 months ago

Thank you for creating this package! :pray:

This PR changes two things in the installation instructions of the README.md.

First, publishing the package config only works once the service provider is registered. Otherwise the service provider class is not found and nothing gets published. That's why I switched the steps around.

Second, running php artisan vendor:publish --provider="SimonSchaufi\LaravelDKIM\DKIMMailServiceProvider" will publish all assets of that service provider. Since this package's DKIMMailServiceProvider extends Illuminate\Mail\MailServiceProvider, the assets of the base class will also be published. This includes default views and resources which are usually not needed when installing this package. I am pretty sure that this is what happened here: https://github.com/simonschaufi/laravel-dkim/discussions/5 Therefore I added --tag dkim-config to the command as a filter, so only the config/dkim.php will be published.

simonschaufi commented 11 months ago

Thank you for your contribution!