simonschaufi / laravel-dkim

Laravel package for signing outgoing messages with DKIM
https://www.simonschaufelberger.de/de/projekte/laravel-packages/laravel-dkim.html
MIT License
24 stars 9 forks source link

Update to Laravel 8.* #2

Closed Lipa77 closed 4 years ago

Lipa77 commented 4 years ago

Change illuminate/mail version to 8.* - should work with Laravel 8

simonschaufi commented 4 years ago

To be backwards compatible, I changed the line slightly. Can you confirm that the code really works with laravel 8?

Lipa77 commented 4 years ago

Unfortunately, I don't know how to check it :(

simonschaufi commented 4 years ago
Lipa77 commented 4 years ago

I have issue with local package: Composer still use Your package from "simonschaufi/laravel-dkim" (instead the local one) ...

Local package is in folder: /packages/simonschaufi/laravel-dkim

My composer file:

    "repositories": {
        "laravel-dkim": {
            "type": "path",
            "url": "/packages/simonschaufi/laravel-dkim",
            "options": {
                "symlink": true
            }
        }
    },
    "require": {      
        "simonschaufi/laravel-dkim": "@dev"
    },
    "config": {
        "preferred-install": "source",
        "sort-packages": true,
        "optimize-autoloader": true
    },
    "minimum-stability": "dev",
    "prefer-stable": true

Do You know what is wrong ????

simonschaufi commented 4 years ago

Please use the path like I wrote it!

Lipa77 commented 4 years ago

I tried it before and does't work for me. So right now I'm looking for the solution on https://stackoverflow.com/questions/64014708/how-to-use-local-composer-packages-in-laravel

simonschaufi commented 4 years ago

This is my root composer.json and it works like this:

{
    "repositories": [
        { "type": "path", "url": "./packages/*" }
    ],
    "require": {
...
        "simonschaufi/laravel-dkim": "@dev",
...
    },
...
}

Please also use "preferred-install": "dist", with source you actually pull the git repository as far as I know.

Lipa77 commented 4 years ago

When I use "url": "./packages/*" I got an error: [ErrorException] Trying to access array offset on value of type null

simonschaufi commented 4 years ago

which version of composer are you using? This error is really strange

Lipa77 commented 4 years ago

You have absolutely right: the problem was because I used old version of Composer. After composer update local package was installed correctly :)

Tomorrow I will check a new version of Your package and let You know. Thanks for Your support!

Lipa77 commented 4 years ago

Checked on laravel 8.6.0 and illuminate/mail 8.5: everything works correctly :)