simonsfoundation / inferelator_ng

Inferelator refactor and generalization.
BSD 2-Clause "Simplified" License
7 stars 14 forks source link

replaced design response R code with python implementation #40

Closed tymor22 closed 7 years ago

tymor22 commented 7 years ago

Replacing design response R code with a python implementation. Add test cases specific to python, remove R code and remove Rdriver file used to execute R code.

nickdeveaux commented 7 years ago

@tymor22 New Travis Error: in python 3.4 (2.7 is passing):

File "pandas/lib.pyx", line 832, in pandas.lib.scalar_compare (pandas/lib.c:14847) TypeError: unorderable types: str() > int()

codecov-io commented 7 years ago

Codecov Report

Merging #40 into master will decrease coverage by 0.19%. The diff coverage is 90.84%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #40     +/-   ##
=========================================
- Coverage   91.48%   91.29%   -0.2%     
=========================================
  Files          23       23             
  Lines        1515     1619    +104     
=========================================
+ Hits         1386     1478     +92     
- Misses        129      141     +12
Impacted Files Coverage Δ
inferelator_ng/bbsr_tfa_workflow.py 0% <0%> (ø) :arrow_up:
inferelator_ng/design_response_translation.py 88.5% <88.5%> (ø)
inferelator_ng/tests/test_design_response.py 97.54% <98.11%> (ø)
inferelator_ng/utils.py 96.66% <0%> (-1.12%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 241e52b...127655e. Read the comment docs.

nickdeveaux commented 7 years ago

Overall, it seems like this new code is just as hard to interpret as the original R code, but that's by design: it's a direct translation of the R code. We're going to disentangle the translation part of this refactor from the re-thinking part. A future pull request will have the re-design of the design_and_response code.

nickdeveaux commented 7 years ago

Travis CI is passing, so 👍 from me to merge.

We'll punt on getting CodeCov up higher until we move the BBSR R code to python.