search

simonsfoundation / inferelator_ng

Inferelator refactor and generalization.
BSD 2-Clause "Simplified" License
7 stars 14 forks source link

removed unused code to make debugging unit tests easier #50

Closed nickdeveaux closed 6 years ago

nickdeveaux commented 7 years ago

We've identified that 2 tests have started to fail due to updates to libraries used that have been updated: https://travis-ci.org/simonsfoundation/inferelator_ng/jobs/257729750 https://travis-ci.org/simonsfoundation/inferelator_ng/jobs/207074744

codecov-io commented 7 years ago

Codecov Report

Merging #50 into master will decrease coverage by 7.62%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
- Coverage   90.17%   82.55%   -7.63%     
==========================================
  Files          23       18       -5     
  Lines        1802     1456     -346     
==========================================
- Hits         1625     1202     -423     
- Misses        177      254      +77
Impacted Files Coverage Δ
inferelator_ng/utils.py 70.21% <ø> (-16.07%) :arrow_down:
inferelator_ng/tests/test_utils.py 100% <ø> (ø) :arrow_up:
inferelator_ng/results_processor.py 62.06% <ø> (-0.44%) :arrow_down:
inferelator_ng/tfa.py 100% <100%> (ø) :arrow_up:
inferelator_ng/tests/test_tfa.py 98.87% <100%> (+0.01%) :arrow_up:
inferelator_ng/gene_model.py 0% <0%> (-98.74%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cb4e7ca...e69ec27. Read the comment docs.

kostyat commented 6 years ago

This looks good. Both bsubtilis and yeast run on my machine, and nosetests pass.