Closed nickdeveaux closed 6 years ago
Merging #56 into master will increase coverage by
0.1%
. The diff coverage is78.47%
.
@@ Coverage Diff @@
## master #56 +/- ##
=========================================
+ Coverage 70.58% 70.69% +0.1%
=========================================
Files 18 19 +1
Lines 1479 1573 +94
=========================================
+ Hits 1044 1112 +68
- Misses 435 461 +26
Impacted Files | Coverage Δ | |
---|---|---|
inferelator_ng/bbsr_python.py | 38.5% <0%> (ø) |
:arrow_up: |
inferelator_ng/design_response_R.py | 0% <0%> (ø) |
|
inferelator_ng/design_response_translation.py | 93.25% <100%> (+4.49%) |
:arrow_up: |
inferelator_ng/tests/test_design_response.py | 98.66% <100%> (+0.5%) |
:arrow_up: |
inferelator_ng/utils.py | 70.58% <100%> (+1.2%) |
:arrow_up: |
inferelator_ng/tfa.py | 100% <100%> (ø) |
:arrow_up: |
inferelator_ng/tests/test_tfa.py | 98.87% <100%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update a654832...5f2cac9. Read the comment docs.
@nickdeveaux I think I need some explanation on what happened here haha :)
Little by little I've been pythonifying design_response_translation.py .
@dayanne-castro trying to make design_response faster and more readable. For example, by adding columns to the existing pandas dataframes, this new code is more efficient and more terse than the old code that used to create new pandas dataframes inside the loop
This pull request is being replaced by https://github.com/simonsfoundation/inferelator_ng/pull/60
@dayanne-castro Fix to the python logic. I think using the right data structure would make this better