simonsmh / blobmoji

Noto Emoji with extended Blob support

SIL Open Font License 1.1

74 stars 9 forks source link

Compatibility with Samsung and HTC based ROMs #8

Closed helmasaur closed 5 years ago

helmasaur commented 5 years ago

Samsung and HTC based ROMs uses a different font file name for emojis.

simonsmh commented 5 years ago

6

helmasaur commented 5 years ago

What do you try to tell me with this link?

simonsmh commented 5 years ago

TL;DR, we don't need or even accept this kind of patch. This is a waste of resources. I parse the fonts.xml to make sure that the correct emoji fonts name is selected that we could make a copy for every Android system, not only for Samsung or HTC but also for more other systems that we don't use before. This has already been fixed once for all. Reference: https://github.com/Magisk-Modules-Repo/blobmoji/blob/master/install.sh#L138-L145

helmasaur commented 5 years ago

Oh, I see what you mean. This is a good idea!