search

simonsmith / cypress-image-snapshot

Catch visual regressions in Cypress with jest-image-snapshot
MIT License
65 stars 15 forks source link

fix(command.ts): align order of variables with error message #51

Closed ramonziai closed 6 months ago

ramonziai commented 6 months ago

I spent a lot of time debugging failed snapshot tests until I found out that the variables for expected and observed image dimensions are swapped in the error message. Can be tested by updating the snapshot and then checking which values change in the message. Fix is to just put them in the correct order.

simonsmith commented 6 months ago

Ah, thanks for spotting this. Just looks like you need to pass the commit lint and then we can get this merged 👌🏻

ramonziai commented 6 months ago

@simonsmith thanks for the quick reaction! Checks are green now, so as far as I am concerned, merge away :smile:

simonsmith commented 6 months ago

@ramonziai Perfect, thank you!

simonsmith commented 6 months ago

:tada: This PR is included in version 9.0.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: