search

simonsmith / stylelint-selector-bem-pattern

Stylelint plugin that incorporates postcss-bem-linter
MIT License
244 stars 13 forks source link

Moves stylelint to peerDependency #68

Closed bmuenzenmeyer closed 9 months ago

bmuenzenmeyer commented 9 months ago

closes #67

5f39bc7f34c96f0b9078c2aedf09a15d6d987c94 - removed package-lock.json - yarn.lock was more recent and package.json defines yarn in the volta config

478b5989a6a1a1ae0017e950e61fb58a896a243f - moved styelint to peerDependencies (to fix #67) and devDependencies (to make tests pass)

ed82ef6276a9d8e815a6980d2852a5f57ec0871a - bumps the package.json version - as this is a potentially breaking change. I could not tell if you have another means to automate versioning and publication, so I can remove this commit if you prefer

simonsmith commented 9 months ago

Thanks @bmuenzenmeyer, this looks good. In terms of the package.json bump, this repo doesn't have any automation on that. Usually just a manual git tag and npm publish.

However I would say that we can delete that commit and publish the 4.0.0 once stylelint has been update to 16.x as per your issue #67. Saves the need for two releases

bmuenzenmeyer commented 9 months ago

@simonsmith I've dropped the commit that incremented the package.json - this still makes https://github.com/simonsmith/stylelint-selector-bem-pattern/commit/478b5989a6a1a1ae0017e950e61fb58a896a243f a BREAKING change because a user expecting stylelint to come along for the ride will no longer have it if not installed directly. I'll leave the timing to you.

ChazUK commented 7 months ago

Hey, is 4.0.0 going to be published soon?

simonsmith commented 7 months ago

Apologies, I totally forgot.

https://www.npmjs.com/package/stylelint-selector-bem-pattern/v/4.0.0

I also took the liberty of updating the package to support stylelint 16.x and their move to ESM. Let me know if there are any issues as I'm not actively using this package, I just ensured tests passed 👍🏻