simonsmith / stylelint-selector-bem-pattern

Stylelint plugin that incorporates postcss-bem-linter
MIT License
244 stars 13 forks source link

Request to move eslint-plugin-jest to devDependency #72

Open castastrophe opened 5 months ago

castastrophe commented 5 months ago

I think eslint-plugin-jest should be listed as a devDependency rather than a dependency. I'm installing the utility and it's showing the following warnings:

"stylelint-selector-bem-pattern > eslint-plugin-jest@27.6.3" has unmet peer dependency "eslint@^7.0.0 || ^8.0.0".
warning "stylelint-selector-bem-pattern > eslint-plugin-jest > @typescript-eslint/utils@5.62.0" has unmet peer dependency "eslint@^6.0.0 || ^7.0.0 || ^8.0.0".
warning "stylelint-selector-bem-pattern > eslint-plugin-jest > @typescript-eslint/utils > @eslint-community/eslint-utils@4.4.0" has unmet peer dependency "eslint@^6.0.0 || ^7.0.0 || >=8.0.0".
warning "stylelint-selector-bem-pattern > eslint-plugin-jest > @typescript-eslint/utils > @typescript-eslint/typescript-estree > tsutils@3.21.0" has unmet peer dependency "typescript@>=2.8.0 || >= 3.2.0-dev || >= 3.3.0-dev || >= 3.4.0-dev || >= 3.5.0-dev || >= 3.6.0-dev || >= 3.6.0-beta || >= 3.7.0-dev || >= 3.7.0-beta".

None of these seem required in order to use this stylelint module. Would a PR be accepted with this update?

simonsmith commented 5 months ago

Hey, yes that makes total sense. Feel free to open a pull request

JoshuaKGoldberg commented 2 days ago

👋 @simonsmith could you please publish this as a new version? #73 was merged but https://www.npmjs.com/package/stylelint-selector-bem-pattern/v/4.0.0 is still the latest published version.