search

simonsobs / LAT_MFLike

Multifrequency Likelihood for SO Large Aperture Telescope
https://lat-mflike.readthedocs.io
Other
4 stars 12 forks source link

TT TE EE likelihood versions with matching nuisance params #89

Closed cmbant closed 2 months ago

cmbant commented 2 months ago

Building on https://github.com/simonsobs/LAT_MFLike/pull/88. Note assumes latest cobaya installed.

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 95.89041% with 3 lines in your changes missing coverage. Please review.

Project coverage is 84.94%. Comparing base (3e669e7) to head (6aefe73).

Files Patch % Lines
mflike/mflike.py 88.88% 2 Missing :warning:
mflike/foreground.py 98.07% 1 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/simonsobs/LAT_MFLike/pull/89/graphs/tree.svg?width=650&height=150&src=pr&token=qrrVcbNCs5&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=simonsobs)](https://app.codecov.io/gh/simonsobs/LAT_MFLike/pull/89?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=simonsobs) ```diff @@ Coverage Diff @@ ## restructure #89 +/- ## =============================================== + Coverage 83.93% 84.94% +1.01% =============================================== Files 3 3 Lines 417 445 +28 =============================================== + Hits 350 378 +28 Misses 67 67 ``` | [Files](https://app.codecov.io/gh/simonsobs/LAT_MFLike/pull/89?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=simonsobs) | Coverage Δ | | |---|---|---| | [mflike/\_\_init\_\_.py](https://app.codecov.io/gh/simonsobs/LAT_MFLike/pull/89?src=pr&el=tree&filepath=mflike%2F__init__.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=simonsobs#diff-bWZsaWtlL19faW5pdF9fLnB5) | `71.42% <100.00%> (ø)` | | | [mflike/foreground.py](https://app.codecov.io/gh/simonsobs/LAT_MFLike/pull/89?src=pr&el=tree&filepath=mflike%2Fforeground.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=simonsobs#diff-bWZsaWtlL2ZvcmVncm91bmQucHk=) | `89.07% <98.07%> (+0.87%)` | :arrow_up: | | [mflike/mflike.py](https://app.codecov.io/gh/simonsobs/LAT_MFLike/pull/89?src=pr&el=tree&filepath=mflike%2Fmflike.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=simonsobs#diff-bWZsaWtlL21mbGlrZS5weQ==) | `82.35% <88.88%> (+0.82%)` | :arrow_up: |
ggalloni commented 2 months ago

This looks good to me!

I think we can also drop the requested_cls in the various MFLike yamls as that attribute is actually inferred from the class name.

To be complete we could also add the missing classes for the other modes combinations that could be useful, TT+EE, TT+TE, and TE+EE (with the corresponding tests). If you want I have them ready and then this is good to go on my side. I'll close my #88.

cmbant commented 2 months ago

Sounds good. Class-name based inference potentially makes it more difficult to inherit variations consistently, may be better to just have requested_cls as before (consistent with the foreground classes like EEForeground)?

cmbant commented 2 months ago

Now merged into omtp https://github.com/simonsobs/LAT_MFLike/pull/88