simonsobs / Pixell.jl

next-generation sky map manipulation on rectangular pixels
MIT License
3 stars 1 forks source link

remove type ambiguity for view slices #59

Closed xzackli closed 1 year ago

xzackli commented 1 year ago

This PR fixes a small bug which caused it to be ambiguous when one slices an Enmap in the first or second dimension. Default behavior for Pixell is to then return a view that views the parent, since the RA or DEC has been removed.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 66.66% and project coverage change: +0.15 :tada:

Comparison is base (6bef1d1) 88.80% compared to head (dca8783) 88.95%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #59 +/- ## ========================================== + Coverage 88.80% 88.95% +0.15% ========================================== Files 11 11 Lines 965 960 -5 ========================================== - Hits 857 854 -3 + Misses 108 106 -2 ``` | [Impacted Files](https://codecov.io/gh/simonsobs/Pixell.jl/pull/59?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=simonsobs) | Coverage Δ | | |---|---|---| | [src/enmap.jl](https://codecov.io/gh/simonsobs/Pixell.jl/pull/59?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=simonsobs#diff-c3JjL2VubWFwLmps) | `70.16% <66.66%> (+0.39%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=simonsobs). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=simonsobs)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.