search

simonsobs / pixell

A rectangular pixel map manipulation and harmonic analysis library derived from Sigurd Naess' enlib.
Other
41 stars 31 forks source link

Set up a conda-forge feedstock #102

Open msyriac opened 4 years ago

msyriac commented 4 years ago

I have no idea how to do this, but given that lots of people use conda, addressing #44 in #94 (pip wheels) is not enough to realize our dream of distributing binaries. So I'm adding it as an issue.

iparask commented 2 months ago

@msyriac, @JBorrow, @amaurea please check here: https://github.com/conda-forge/staged-recipes/pull/27279

If you want to be a maintainer, otherwise let me know to remove you.

JBorrow commented 2 months ago

We need a fortran compiler as well as a C compiler

msyriac commented 2 months ago

Happy to be listed as a maintainer

iparask commented 2 months ago

I will add the fortran compiler. Can you add the maintainer acceptance comment in the PR? The reviewers will check there

iparask commented 2 months ago

Does pixell assume a specific fortran compiler version: https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=1014635&view=logs&j=6f142865-96c3-535c-b7ea-873d86b887bd&t=22b0682d-ab9e-55d7-9c79-49f3c3ba4823

Line 12674.

Also the whole code has warnings for tabs. I will try to silence it, but I would prefer spaces.

msyriac commented 2 months ago

It does not; it has worked with many recent versions of GNU and Intel. I haven't looked at it in detail, but a quick glance looks like this error isn't related to the compiler but how the build has been set up (it's trying to find calc_weights which is defined in interpol.F90)

iparask commented 2 months ago

I silenced all the warnings with - FFLAGS=-Wno-tabs -Wno-conversion -Wno-unused-variable and it still fails.

https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=1014665&view=logs&j=6f142865-96c3-535c-b7ea-873d86b887bd&t=22b0682d-ab9e-55d7-9c79-49f3c3ba4823

Lines 1505 - 1523

The function is wrapped and that shows in line 1432. There is something else here that is happening which I am not sure. I'll try a few more possible solutions and I'll see

iparask commented 1 month ago

The conda-forge recipe was merged. That sets pixell to be part of the conda forge channel.

Their bots have already created a feedstock repository (https://github.com/conda-forge/pixell-feedstock). As soon as that is populated it will create the image.

This will be the repo that we need to keep up to date for pixell to continuously be part of conda-forge