Fix for Intel compilers

simonsobs / pixell

A rectangular pixel map manipulation and harmonic analysis library derived from Sigurd Naess' enlib.

Other

42 stars 32 forks source link

Fix for Intel compilers #254

Closed msyriac closed 7 months ago

msyriac commented 7 months ago

Removed "intrinsic" from scripts/omp_hello.f90. With ifort, this was giving:

$ ifort -qopenmp scripts/omp_hello.f90
scripts/omp_hello.f90(4): error #7002: Error in opening the compiled module file.  Check INCLUDE paths.   [OMP_LIB]
    use, intrinsic :: omp_lib
----------------------^
scripts/omp_hello.f90(12): error #6404: This name does not have a type, and must have an explicit type.   [OMP_GET_THREAD_NUM]
        print '("Thread: ", i0)', omp_get_thread_num()
----------------------------------^
compilation aborted for scripts/omp_hello.f90 (code 1)

(h/t @nolta)

msyriac commented 7 months ago

Looks like I also snuck in a sad docstring update.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 43.65%. Comparing base (a5e4470) to head (b1a5db2).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #254 +/- ## ========================================== + Coverage 43.60% 43.65% +0.04% ========================================== Files 34 34 Lines 10964 10964 ========================================== + Hits 4781 4786 +5 + Misses 6183 6178 -5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

JBorrow commented 7 months ago

Sorry for taking so long with this. I'm happy with this, though I will say that your new docstring is not particularly helpful :).

msyriac commented 7 months ago

I agree, certainly not something that will help us close #15 now :)