Closed adrien-laposta closed 2 years ago
Merging #24 (8ace5d7) into master (9e4251d) will decrease coverage by
1.19%
. The diff coverage is0.00%
.
@@ Coverage Diff @@
## master #24 +/- ##
==========================================
- Coverage 32.45% 31.26% -1.20%
==========================================
Files 17 18 +1
Lines 1781 1849 +68
==========================================
Hits 578 578
- Misses 1203 1271 +68
Impacted Files | Coverage Δ | |
---|---|---|
pspy/so_consistency.py | 0.00% <0.00%> (ø) |
Few things: 1) Don't use upper case, in pspy we prefer using underscore (e.g n_bins rather than nBins) 2) The TF deconvolution should not be done in this function : get_spectraVec_and_fullCov, since removing TF is of general interest, we should have another routine in pspy that takes care of that 3) I'm not sure I understand the build of fullCov, do you need to loop on all i,j and then symmetrize?, or could you loop on i, j<=i and then symmetrize ? 4) We should have a tutorial script using these functions 5) Why is the chi2 computed in plot_residual not using the get_chi2 function ? 6) we need a better name than get_spectraVec_and_fullCov, append_spectra_and_cov ?, also the description should be way more general, it has nothing to do with array, it just take spectra, make a single vector and get the corresponding covariance matrix, I also don't think it should work with filenames, I think the general case would be to pass actual spectra and cov that were previously computed rather than passing file name (you might want to use this function on the fly)