simonsobs / scheduler

Scheduler for SO
0 stars 1 forks source link

add ability to change elevation of sun parking spot #112

Closed ykyohei closed 1 month ago

ykyohei commented 1 month ago

To resolve https://github.com/simonsobs/scheduler/issues/111 Add ability to change elevation of sun parking spot. This is critical for operation in the Chilean summer with larger sun avoidance. We configure the minimum allowed elevation in each policy. Also, added more info in the error log.

This will change the sun avoidace part of schedule like this, if it is necessary to change elevation.

run.wait_until('2024-10-07T14:48:24+00:00')
run.acu.move_to(az=180.0, el=60.0)
run.acu.move_to(az=180.0, el=48)
run.wait_until('2024-10-07T14:53:24+00:00')
run.acu.move_to(az=180.0, el=48)
run.wait_until('2024-10-07T18:57:35.980000+00:00')
run.acu.move_to(az=111.483, el=48)
run.acu.move_to(az=111.483, el=60.0)
run.wait_until('2024-10-07T19:02:35.980000+00:00')
run.acu.move_to(az=111.483, el=60.0)
mhasself commented 1 month ago

I don't see where this actually changes the elevation. Missing a commit?

There's another PR (#108 ) in to set the platform min_el, in a different way, so we're diverging here...

ykyohei commented 1 month ago

@guanyilun Do you have opinion/suggestion on how we converge the treatment of min_el?

guanyilun commented 1 month ago

I'm ok with setting the min_el as part of the sun policy for now. I intend to do a refactoring to provide more direct access to policy configs, so I might change this in the future.