simonsobs / scheduler

Scheduler for SO
0 stars 1 forks source link

Suboptimal az path is chosen in some cases #75

Open mhasself opened 2 months ago

mhasself commented 2 months ago

The function recur is intended to find the best az values (taking into account branch options and sun avoidance) at which to run each operation.

I suspect this function isn't implemented correctly. The example in https://github.com/simonsobs/scheduler/issues/73 shows one consequence of the implementation -- the scheduler injects a move_to(az=52.0) unnecessarily; I think it could have just stayed at az=218 (or so) to do the bias_step. This happens because of some interaction with sun avoidance -- but I am finding it difficult to tell what the purpose of the function is, precisely.

I hereby request, for this specific az path optimization:

guanyilun commented 1 week ago

Should I close this now since recur is superseded by a better implementation from @mhasself? I understand the need of better unit tests, which could be tracked in a separate issue under a better name.

mhasself commented 1 week ago

Fine with me but consider just putting in a few unit tests, and establishing that framework, and then you could close this issue without having to make a new one! $$$