Allow setting http port in environment var

simonsobs / sisock

Sisock ('saɪsɒk): streaming of Simons Obs. data over websockets for quicklook

Other

2 stars 0 forks source link

Allow setting http port in environment var #21

Closed guanyilun closed 5 years ago

guanyilun commented 5 years ago

A quick edit for issue #20

BrianJKoopman commented 5 years ago

This looks great. One question, why default to port 3006?

guanyilun commented 5 years ago

This looks great. One question, why default to port 3006?

It's a random port that I used to test. I changed it back. Sorry!

BrianJKoopman commented 5 years ago

No problem, it's the default Klein development port, which maybe means it'd be better if we chose something different, but since it already may be configured for some people it'd be good to leave it. Also, it's internal to the Docker network, so probably isn't a big deal.

Thanks for the patch!