Closed dixilo closed 3 weeks ago
Thanks for submitting this PR @dixilo! And apologies for the slow reply following the holidays. With five agents and nearly 3,000 lines this is going to take a while to get through. It would be helpful on the reviewer side, based on past experience with groups of agents like the HWP agents, if you could break this up into separate PRs per agent. That way it's a bit less daunting of a review, issues in one agent won't hold up merging of other agents, and we could have different team members review different agents more easily. Would you mind doing that?
Yes, I can split this PR to separate PRs per agent.
What do you think is the best way to split PR?
Making branches per agent from main
and then copy files by git checkout -p [commit id] [file name]
to these branches is the best way to do this?
Please let me know if you have any idea @BrianJKoopman .
Yes, I can split this PR to separate PRs per agent. What do you think is the best way to split PR? Making branches per agent from
main
and then copy files bygit checkout -p [commit id] [file name]
to these branches is the best way to do this? Please let me know if you have any idea @BrianJKoopman .
Thanks @dixilo! There isn't a ton of history here, sort of up to you on how much you want to preserve it. If not at all, I'd make different branches per agent and just re-commit the relevant agent code per branch.
If you'd like to preserve the history here, I'd probably create a new branch for each agent at the head of this stimulator
branch, then do an interactive rebase (git rebase -i main
) on each and 'edit' the commits to drop the agents unrelated to the named agent branch. For particular agents this'll mean just dropping certain commits. Not sure if there's an easier way to split this out.
Description
This pull request contains several agents and driver codes to handle devices for LAT stimulator. New agents are:
Motivation and Context
These codes will be used to operate the LAT stimulator.
How Has This Been Tested?
We tested the functionality by actual devices which will be deployed to the site.
Types of changes
Checklist: