Closed bkelle closed 6 months ago
Looks good to me! a few inline comments. Also need to register the OCS operation at the bottom of the file.
I'd like this to be tested before merging, so we should work out when to do that.
I've made the requested changes, and registered the OCS operation at the end of the file! This should be good to test, I will interface with the site team to see when a good time for me to do that will be.
Looks good to me, there was a stray decorator added to another task that should be removed (see below.)
Also, this bias wave code isn't merged upstream in sodetlib yet, so those tests are going to keep failing, and the build isn't going to work. That should be merged first.
This was merged in sodetlib here can we rerun ci tests somehow?
Merging in the latest main
would do it.
@BrianJKoopman this test failure doesn’t seem related to anything we added.
@BrianJKoopman this test failure doesn’t seem related to anything we added.
Yup, agreed. Not sure why this is cropping back up suddenly, but #643 should work around the issue here.
Alright, #650 dropped the unrelated tests that are being flaky. Merge in the latest main
when you're ready.
Sorry, one more merge of the latest main
. #652 drops the now failing tests.
adding in code for bias waves. Essentially copying the bias step code block and modifying for bias wave analysis.
Description
adding in agent task for bias waves in similar form to bias step
Motivation and Context
Needed to be able to run bias waves in nextline