simonsobs / socs

Simons Observatory specific OCS agents.
BSD 2-Clause "Simplified" License
12 stars 12 forks source link

Change check range of gripper distance #635

Closed ykyohei closed 4 months ago

ykyohei commented 4 months ago

Change check range of gripper distance from 10 mm to 20 mm.

Description

Since the actuator distance of the SATP3 is greater than 10 mm, it is helpful to allow a distance of up to 20 mm for the operation of the SATP3 gripper.

How Has This Been Tested?

No testing is required because this is a very minor change.

Types of changes

Checklist:

ykyohei commented 4 months ago

What happens if satp1 tries to move beyond the previous limit of 10 mm?

If the actuator tries to move further than the grip distance (physical limit), the gipper motor reaches the current limit and raise an alarm and stop. But this is how we firmly grip hwp. Also we can reach the physical limit by moving short distance multiple times. The grip distance is different for different actuators and different SATs. https://simonsobs.atlassian.net/wiki/spaces/PRO/pages/185434251/CHWP+main+page#Actuator-distance

I think it's also fine to just delete this limit.

bbixler500 commented 4 months ago

I agree that it is safe to remove the limit as well. Notably this was only a limit for a single move command (you could call two 10mm move commands in succession without issue to end up at 20mm). The limit was originally in place because I did not imagine there was ever a need to move more than 10mm at once. This is obviously not true anymore.

BrianJKoopman commented 4 months ago

Great, let's just drop the check argument in that decorator then.