simonsobs / socs

Simons Observatory specific OCS agents.
BSD 2-Clause "Simplified" License
12 stars 12 forks source link

Issue with pysmurf-controller publishing infs #645

Closed jlashner closed 2 months ago

jlashner commented 3 months ago

I think in both SATp1 and SATp3 we've seen the following error in the schedule, caused by a pysmurf-controller:

ocs.client_http.ControlClientError: [0, 0, 0, 0, 'wamp.error.runtime_error', ['Session.data cannot store inf/-inf; please convert to NaN.'], {}]

(I wish there were a better way to copy logs from loki...)

image

This happens immediately after try to return from the bias step task:

image

There must be an inf showing up in the quantiles here somehow: https://github.com/simonsobs/socs/blob/6d3a2c28d1b41f632d9fced088c19f90757952d4/socs/agents/pysmurf_controller/agent.py#L804

We should figure out whatever masking we need to do to this array to stop this from happening.

BrianJKoopman commented 3 months ago

(I wish there were a better way to copy logs from loki...)

If you find the log segment you want there's a download button to download the logs as a text file. (Still not the most convenient thing, but perhaps better?)