Changed string handling to account for multiple responses

bbixler500 commented 2 months ago

Attempts to fix ValueError when multiple values are returned because of timeout as is discussed in #651

Description

Changes internal logic so that only the most recent response string is used

Motivation and Context

Attempt to fix #651

How Has This Been Tested?

This has not been tested as of yet and I will update with a comment when it has.

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

ykyohei commented 2 months ago

@bbixler500 The test is failed. Maybe we need to fix the test?

bbixler500 commented 2 months ago

I'm not sure what these test errors are for. They seem to be in relation to the Lakeshore240 and Lakeshore425 so I don't know why they are showing up here

BrianJKoopman commented 2 months ago

I'm not sure what these test errors are for. They seem to be in relation to the Lakeshore240 and Lakeshore425 so I don't know why they are showing up here

Sorry, this was caused by a new release of OCS. Fixed in #664. Please merge in the latest from main.

simonsobs / socs