search

simonsobs / sodetlib

Tools for performing core instrument testing, quality control, and analysis tasks.
BSD 2-Clause "Simplified" License
5 stars 0 forks source link

Change stream_g3_on kwarg make_freq_mask default to False #425

Closed jlashner closed 6 months ago

jlashner commented 6 months ago

The make_freq_mask function involves a lot of EPICS calls and takes a long time to run. This is currently causing some issues on SAT1, and as far as I know the resulting "freq.txt" file is not use anywhere in SO.

This changes the stream defaults so that it does not attempt to make a frequency mask.

jlashner commented 6 months ago

Just checked and this is the only instance of freq.txt in all of sotodlib, so I think we should be ok to remove it without testing: https://github.com/simonsobs/sotodlib/blob/1e85b2c3a41c329cb396cd278a81fa3a05e48ee7/sotodlib/io/imprinter.py#L677-L679

msilvafe commented 6 months ago

Just checked and this is the only instance of freq.txt in all of sotodlib, so I think we should be ok to remove it without testing: https://github.com/simonsobs/sotodlib/blob/1e85b2c3a41c329cb396cd278a81fa3a05e48ee7/sotodlib/io/imprinter.py#L677-L679

Ok thanks for double checking.