search

simonsobs / sodetlib

Tools for performing core instrument testing, quality control, and analysis tasks.
BSD 2-Clause "Simplified" License
5 stars 0 forks source link

Update bias_dets.py #427

Closed dpdutcher closed 3 months ago

dpdutcher commented 3 months ago

In biasstep_rebias: it should be cfg.dev.exp, not cfg.dev.experiment

msilvafe commented 3 months ago

I'm a bit confused why you needed this change. The device config code loads everything in the experiment section of the dev_cfg yaml into cfg.exp: https://github.com/simonsobs/sodetlib/blob/514b8b16042ab10496639b89d4fb98154cfa7495/sodetlib/det_config.py#L114-L172

dpdutcher commented 3 months ago

cfg.dev does not have an "experiment" attribute, it only has a "exp" attribute. So sleep_time = cfg.dev.experiment["overbias_sleep_time_sec"] fails with an attribute error.

msilvafe commented 3 months ago

cfg.dev does not have an "experiment" attribute, it only has a "exp" attribute.

So sleep_time = cfg.dev.experiment["overbias_sleep_time_sec"] fails with an attribute error.

Ahh ok I read this wrong I thought you were changing exp -> experiment not the other way around.