simonsobs / sodetlib

Tools for performing core instrument testing, quality control, and analysis tasks.
BSD 2-Clause "Simplified" License
5 stars 0 forks source link

complex impedance crashes on dict_to_am because cryocard fw is tuple #428

Closed dpdutcher closed 1 month ago

dpdutcher commented 3 months ago

https://github.com/simonsobs/sodetlib/blob/8c0d2931abb48723aea3ca65398fd515d42d91f2/sodetlib/operations/complex_impedance.py#L28

The above line in new_ci_dset raises a ValueError because the cryocard_fw_version is returned as a tuple, which dict_to_am cannot handle. Either need to change this line to

ds.wrap('meta', sdl.dict_to_am(sdl.get_metadata(S, cfg), skip_bad_types=True))

or convert the cryocard_fw_version to a numpy array at some point within dict_to_am or get_metadata