We ran run.smurf.uxm_relock for the first time at site recently. Turns out test_mode isn't an argument for the actual agent (only in the mock controller agent sorunlib development was done against.)
In nextline we end up with:
Traceback (most recent call last):
File "<string>", line 35, in <module>
File "/usr/local/lib/python3.10/dist-packages/sorunlib/smurf.py", line 151, in uxm_relock
check_response(resp)
File "/usr/local/lib/python3.10/dist-packages/sorunlib/_internal.py", line 23, in check_response
op = response.session['op_name']
KeyError: 'op_name'
And on the backend in the pysmurf-controller:
2023-11-13T19:50:38+0000 start called for uxm_relock
2023-11-13T19:50:38+0000 Caught ParamError during start call: params included unexpected values: ['test_mode']
We ran
run.smurf.uxm_relockfor the first time at site recently. Turns outtest_modeisn't an argument for the actual agent (only in the mock controller agent sorunlib development was done against.)In nextline we end up with:
And on the backend in the pysmurf-controller:
This line is at fault: https://github.com/simonsobs/sorunlib/blob/a08ce5f475ef0a3453448a9018409e45d6fd0403/src/sorunlib/smurf.py#L140
We should just check for
test_modebefore sending it as an argument. I don't expect it'll be implemented in the real agent.