search

simonsobs / sotodlib

Simons Observatory: Time-Ordered Data processing library.
MIT License
16 stars 19 forks source link

hwp angle model metadata #915

Closed ykyohei closed 3 months ago

ykyohei commented 3 months ago

This PR adds new hwp_angle_model metadata. hwp_angle_model metadata is for tracking the version of hwp_angle_model, it does not add new functionality to apply_hwp_angle_model. site_pipeline.make_hwp_angle_model.py is a script that will generate hwp_angle_model metadata and we will manage the version manually.

I think there can be a much better implementation of versioning hwp_angle_model or make_hwp_angle_model.py, so I start this PR as a draft. For example, versioning a yaml file or text file seems sufficient for this? I would appreciate any suggestions.

We have to merge this PR and update use_this.yaml at the same time. My plan of merging procedure is to make a hwp_angle_model metadata in my local directory and ask admin to copy metadata files to the shared directory in site-computing. Then, we wait until hwp_angle_model metadata is synced to NERSC etc. Finally, we merge this PR and update the use_this.yaml at site-computing.

ykyohei commented 3 months ago

Addressed suggestions. PR for the scripts for hwp_angle_model is https://github.com/simonsobs/pipeline-metadata-scripts/pull/1 @17-sugiyama I would appreciate if you could doble check.

ykyohei commented 3 months ago

Done and tested it!